SSF-167 Update pantry/manufacturer applications endpoints#133
Open
SSF-167 Update pantry/manufacturer applications endpoints#133
Conversation
Juwang110
changed the title
amywng
requested changes
Mar 16, 2026
apps/backend/src/foodManufacturers/manufacturers.controller.spec.ts
Outdated
Show resolved
Hide resolved
amywng
approved these changes
Mar 17, 2026
|
|
||
| if (manufacturer?.foodManufacturerRepresentative.id !== currentUserId) { | ||
| throw new BadRequestException( | ||
| `User ${currentUserId} is not allowed to edit manufacturer ${manufacturerId}`, |
Member
There was a problem hiding this comment.
nit: can we do "edit application for Food Manufacturer {id}", same for pantries
| throw new NotFoundException(`Pantry ${pantryId} not found`); | ||
| } | ||
|
|
||
| if (pantry?.pantryUser.id !== currentUserId) { |
Member
There was a problem hiding this comment.
with the above check do we need this ? same question for manufacturers service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-167
📝 Description
Added endpoints for updating existing pantry and manufacturer applications.
In manufacturer controller:
/:manufacturerId/update-application
In pantry controller:
/:pantryId/update-application
✔️ Verification
I wrote controller tests for both and service tests for the pantry route as we have yet to define manufacturer service tests. I also tested functionality with postman.
🏕️ (Optional) Future Work / Notes
N/A