Open
Conversation
sam-schu
requested changes
Mar 18, 2026
Collaborator
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
The spacing between the stat boxes looks too wide, and the font weight looks too thin
| stats: Record<string, string>; | ||
| }; | ||
|
|
||
| // Called like: <DashboardStats stats={{ Food Requests: '1200', Orders: '50', Items Received: '1000', Value Received: '$40',}}></DashboardStats> |
Collaborator
There was a problem hiding this comment.
I think at least the multi-word keys in this example need quotes
| const colors = ['blue.core', 'red', 'yellow.hover', 'teal.hover']; | ||
|
|
||
| return ( | ||
| <SimpleGrid columns={4} gap={10} mx={8} my={4}> |
Collaborator
There was a problem hiding this comment.
Why does this specify 4 columns, but the color mapping seems to be written to support any number of columns?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-168
📝 Description
Created a reusable dashboard stats component that will be used by all different dashboard types.
✔️ Verification
I temporarily made a new page with the component imported to verify the design matched figma
🏕️ (Optional) Future Work / Notes
N/A