fix: include codspeed iteration in --version output#11
Merged
not-matthias merged 2 commits intoMay 26, 2026
Merged
Conversation
Derive v_suffix_ver in configure.ac from the top entry of debian/changelog so AC_INIT picks up the codspeedN iteration automatically, and join it with '-' to match the git-tag / deb-version format. Before: valgrind-3.26.0.codspeed After: valgrind-3.26.0-codspeed2
not-matthias
force-pushed
the
cod-2674-properly-compare-codspeed-valgrind-versions-for-the-same
branch
from
e43a85b to
5678fd5
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
The check looked for '.codspeed' but the version separator is now '-' (e.g. valgrind-3.26.0-codspeed2), so the iteration leaked into test IDs and broke comparison against historical runs. Match the plain 'codspeed' substring so both old and new formats normalize to 'valgrind.codspeed'.
not-matthias
deleted the
cod-2674-properly-compare-codspeed-valgrind-versions-for-the-same
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive v_suffix_ver in configure.ac from the top entry of debian/changelog so AC_INIT picks up the codspeedN iteration automatically, and join it with '-' to match the git-tag / deb-version format.
Before: valgrind-3.26.0.codspeed
After: valgrind-3.26.0-codspeed2