Skip to content

chore: move object skip logic into instrument hooks #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 3 commits into from
May 22, 2026
Merged

chore: move object skip logic into instrument hooks #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d381e9
chore: sync includes/callgrind.h with valgrind-codspeed
not-matthias May 20, 2026
7742f48
ci: fail when includes/callgrind.h drifts from the valgrind fork
not-matthias May 20, 2026
b9ddb5b
feat: add instrument_hooks_callgrind_add_obj_skip
not-matthias May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,22 @@
with:
extra_args: --all-files

check-callgrind-header:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Diff includes/callgrind.h against valgrind-codspeed main
run: |
curl -fsSL -o /tmp/callgrind.h \
https://raw.githubusercontent.com/CodSpeedHQ/valgrind-codspeed/master/callgrind/callgrind.h
if ! diff -u /tmp/callgrind.h includes/callgrind.h; then
echo ""
echo "::error::includes/callgrind.h is out of sync with CodSpeedHQ/valgrind-codspeed."
echo "Copy callgrind/callgrind.h from the fork's default branch into includes/."
exit 1
fi

tests:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
strategy:
matrix:
os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest]
Expand Down Expand Up @@ -269,6 +284,7 @@
if: always()
needs:
- lint
- check-callgrind-header
- tests
- build
- test-build-cmake
Expand Down
Loading
Loading