🪵 refactor: Improve OpenID redirect origin handling and startup logs#50
Merged
Conversation
- Added a new function to extract the request origin from headers, enhancing cross-origin request handling. - Updated OpenID check and login functions to utilize the new origin extraction logic. - Restored the warning for unset ADMIN_PANEL_METRICS_SECRET, ensuring visibility for metrics endpoint access issues. - Refactored server initialization to log the correct port number.
- Introduced a new function to reliably extract the request origin from headers, improving handling of cross-origin requests. - Updated OpenID login and OAuth exchange functions to utilize the new origin extraction logic, ensuring correct redirect URIs. - Removed redundant origin handling code, streamlining the request processing flow.
danny-avila
changed the title
teresama
approved these changes
May 11, 2026
dustinhealy
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun run build.