Skip to content

Add typings for the remaining HTTP settings#479

Open
andreygmc wants to merge 2 commits intoClickHouse:mainfrom
andreygmc:resolve53
Open

Add typings for the remaining HTTP settings#479
andreygmc wants to merge 2 commits intoClickHouse:mainfrom
andreygmc:resolve53

Conversation

@andreygmc
Copy link
Copy Markdown

@andreygmc andreygmc commented Nov 12, 2025

Summary

Added missing http settings:
"compress", "decompress", "quota_key", "buffer_size"

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 12, 2025

CLA assistant check
All committers have signed the CLA.

@slvrtrn
Copy link
Copy Markdown
Contributor

slvrtrn commented Nov 12, 2025

Added missing http settings:
"compress", "decompress", "user", "password", "quota_key", "query_id", "buffer_size", "wait_end_of_query", "session_id", "session_timeout", "session_check"

Why do we need user, password, query_id, session_id in the settings? Those are first-class config options already.

wait_end_of_query, session_timeout, session_check are already defined.

@andreygmc
Copy link
Copy Markdown
Author

Thanks. I have removed these options. And what about compress and decompress? Are they already defined in CompressionSettings?

Comment on lines +1600 to +1603
/** If you specify compress=1, the server will compress the data it sends to you. */
compress: Bool
/** If you specify decompress=1, the server will decompress the data which you pass in the POST method. */
decompress: Bool
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like these should be covered by:

export interface CompressionSettings {
decompress_response: boolean
compress_request: boolean
}

* and the remaining data is sent directly to the HTTP channel.
* To ensure that the entire response is buffered, set wait_end_of_query=1.
* In this case, the data that is not stored in memory will be buffered in a temporary server file. */
buffer_size: UInt64
Copy link
Copy Markdown
Collaborator

@peter-leonov-ch peter-leonov-ch Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like http_response_buffer_size can covers this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants