Add typings for the remaining HTTP settings#479
Add typings for the remaining HTTP settings#479andreygmc wants to merge 2 commits intoClickHouse:mainfrom
Conversation
Why do we need
|
|
Thanks. I have removed these options. And what about compress and decompress? Are they already defined in CompressionSettings? |
| /** If you specify compress=1, the server will compress the data it sends to you. */ | ||
| compress: Bool | ||
| /** If you specify decompress=1, the server will decompress the data which you pass in the POST method. */ | ||
| decompress: Bool |
There was a problem hiding this comment.
Seems like these should be covered by:
clickhouse-js/packages/client-common/src/connection.ts
Lines 29 to 32 in f6822bd
| * and the remaining data is sent directly to the HTTP channel. | ||
| * To ensure that the entire response is buffered, set wait_end_of_query=1. | ||
| * In this case, the data that is not stored in memory will be buffered in a temporary server file. */ | ||
| buffer_size: UInt64 |
There was a problem hiding this comment.
Seems like http_response_buffer_size can covers this?
Summary
Added missing http settings:
"compress", "decompress", "quota_key", "buffer_size"
Checklist
Delete items not relevant to your PR: