[repo] Adopt CLI tests from ClickHouse client#2772
Open
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
mzitnik
reviewed
Mar 9, 2026
Contributor
mzitnik
left a comment
mzitnik
left a comment
There was a problem hiding this comment.
I think using already built libraries can reduce the code size and make it easier to maintain
| appendLog(logPath, "argv=" + String.join(" ", args)); | ||
|
|
||
| for (int i = 0; i < args.length; i++) { | ||
| ParsedOption option = parseOption(args[i]); |
Contributor
There was a problem hiding this comment.
Why not use a library like https://commons.apache.org/proper/commons-cli/
Contributor
Author
There was a problem hiding this comment.
yes, we can add it.
| } | ||
| String val = rs.getString(i); | ||
| if (val == null) { | ||
| line.append("\\N"); |
| } | ||
| } | ||
|
|
||
| private static void writeResultSetAsTsv(ResultSet rs) throws Exception { |
Contributor
There was a problem hiding this comment.
why no to use https://commons.apache.org/proper/commons-csv/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Adds a new Maven-built Java CLI and wrapper script used by
clickhouse-test, including a SNAPSHOT dependency and argument/setting parsing that could affect test execution and reproducibility.Overview
Introduces a new
tests/clickhouse-clientMaven project that builds a shaded Java CLI to mimicclickhouse-clientfor running ClickHouse’sclickhouse-testsuites against a server.The CLI supports two execution backends (
clientvia client-v2 API orjdbc), reads queries from--queryor stdin (with optional--multiquerysplitting), forwards a small set of server settings, and writes debug logs viaCLICKHOUSE_CLIENT_CLI_LOG. Abin/clickhousewrapper is added to invoke the fat JAR and provide minimalextract-from-configcompatibility expected by the upstream test runner.Written by Cursor Bugbot for commit c290e9d. This will update automatically on new commits. Configure here.