Conversation
Member
brachy84
commented
Mar 30, 2026
brachy84
commented
- replace OreDictIngredient with IIngredient
- remove ItemStack methods if possible (since its an IIngredient)
WaitingIdly
approved these changes
Apr 1, 2026
| @MethodDescription(description = "groovyscript.wiki.thaumcraft.aspect_helper.add_item", type = MethodDescription.Type.ADDITION) | ||
| public void add(ItemStack item, AspectStack aspect) { | ||
| this.add(item, aspect, true); | ||
| public void add(IIngredient oreDict, AspectStack aspect) { |
Collaborator
There was a problem hiding this comment.
maybe rename oreDict to ingredient? (also in a few other places)
| public void add(IIngredient ingredient, AspectStack aspect, boolean doBackup) { | ||
| if (ingredient != null && aspect != null) { | ||
| ItemStack[] ores = ingredient.getMatchingStacks(); | ||
| if (ores != null) { |
Collaborator
There was a problem hiding this comment.
i dont think we do nullchecks for IIngredient#getMatchingStacks - it should always be an empty array. also applies to line 218.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.