Fix fastsync hanging when file vanishes#21
Merged
Conversation
yannickhilber
approved these changes
Mar 31, 2026
yannickhilber
left a comment
yannickhilber
left a comment
There was a problem hiding this comment.
Thanks it works well !
We have the errors at the top level, we could avoid panicking and handle them more cleanly.
Right now when the file is removed after fastsync send is invoked both receiving and sending sides will hand indefinitely. This fixes this issue by exitting the sender with an error, which in turn makes receiver to fail as not all data was received.
Szymongib
force-pushed
the
fix-vanished-file-hang
branch
from
b39f6ea to
4029a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when the file is removed after fastsync send is invoked both receiving and sending sides will hand indefinitely. This fixes this issue by exitting the sender with an error, which in turn makes receiver to fail as not all data was received.
This also improves error handling a bit and adds test to reproduce the issue.