All bugfixes and new checks for Redfish integration

[Yogibaer75]

Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.

General information

Extensions to the current Redfish checks (CMK 2.4.0p18)

• Inventory data
• PDU status
• Power consumption & redundancy
• modifications to special agents for the new checks
• HW/SW inventory same path for firmware and hardware components
• checks of storage controllers can be configured to be full or rollup only
• ignore some stupid device levels of 0 degrees on some HPE temp sensors
• same output for SSD utilization and SSD wear level --> Media Life Left

Extension was tested with 30 Redfish mockup servers and had no error message.

It would be good to have this also in 2.4 and 2.5 as the master is way different than the current versions.
Or should i make a PR with these to 2.4 & 2.5 also?

BR
Andreas

[Yogibaer75]

A little bit of context to the single changes.

Inventory data

Integration of existing firmware inventory with data from system and chassis.

[Yogibaer75]

PDU status

Power consumption and redundancy

and power redundancy or

[github-actions]

Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days.
Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.

This pull request will be closed due to inactivity after 60 days, if no action is taken.

[Yogibaer75]

The file inv_redfish_firmware_hpe_ilo4.py was not used at any time. With the first commit it was accidentally included.

[Yogibaer75]

The last commit fixes an rare bug with the power redundancy check where you get empty data from the Redfish interface.

[Yogibaer75]

Added latest PR from @Ma7h1 - feature documented here Yogibaer75/Check_MK-Things#105 (comment)

[Yogibaer75]

Some more bugfixes.

• discovery option for drive item names
• discovery option for volume item names
  here are an example what could happen before

Bottom shows the naming before and on top with the new style. Default style is old style to have no "imcompatible changes" The same is the shown volume is also done for drives.

Second example

[smeagol91]

Hello Andreas,

thank you for that pull request. We've merged it with some minor modifications. (It will be here soon.) I want to let you know about the what and why we changed things.

1. Structural changes

• Split graphing/power.py into two files power.py for PSU metrics, power_consumption.py for the new power metrics. We want to have each graphing module to contain either standalone metrics or exactly one cohesive bundle. The mixing of both in one file needs to be avoided.
• Moved the inventory UI node definition into the Redfish plugin package (inventory_ui/hardware.py) instead of the central collection package, to keep the plugin self-contained.
• Added checkman pages for the new checks, to have some informations for the users about this new checks.

2. Code changes

• Removed the debug line from redfish_pdus.py:48
• Fixed some typos check_plugin_redfish_storage / "chassis"
• Added a CannotRecover exception also into agent_redfish_power.py when PowerEquipment endpoint is missing. This prevents a crash when the power agent is pointed at a non-PDU device.
• Added a URL guard in agent_redfish.py if a section exists but has no @odata.id, we skip it instead of passing None.
• Battery status check now maps "Degraded"/"Warning" to WARN instead of CRIT, since degraded shouldn't be CRIT.
• Consistent get("Id", key) fallback in both discovery and check functions for PDUs.

3. Code improvements

• Replaced Mapping[str, Any] with RedfishAPIData type where the data is actually Redfish section data (not for the params).
• Replaced dict[str, object] in test fixtures, using dict[str, Any] to match the API pattern.

4. Unit Tests

• Added unit tests for all new and modified checks

Everything will be backported to 2.5.0 and 2.4.0. The werk (#19552) will credit you as the contributor. Thanks again for the comprehensive enhancement!

Best Regards
Sebastian