[ENG-10529] Users can still submit to registries that are closed to new submissions#903
Open
mkovalua wants to merge 3 commits intoCenterForOpenScience:feature/pbs-26-2from
Open
[ENG-10529] Users can still submit to registries that are closed to new submissions#903mkovalua wants to merge 3 commits intoCenterForOpenScience:feature/pbs-26-2from
mkovalua wants to merge 3 commits intoCenterForOpenScience:feature/pbs-26-2from
Conversation
…dmin and create back redirection if /new is access for not allowed registry provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In admin, the Product Team can determine when a registry (and other services) are open for new submissions. When closed, a user would see no “Add registration” button when on the registration pages, and direct submission links (ie https://osf.io/registries/dataarchive/new) will throw a not allowed error and not allow submissions. However, registries closed to submissions can be submitted to freely. This is a misleading status, and confusing for users and members.
For example, the Character Lab Registry has been closed to submission for several years but is now available for submissions: https://osf.io/registries/characterlabregistry
Summary of Changes
Not render
Add Registrationbutton ifallow_submissionsis set to false in adminredirect and show error message if on link /new access
allow_submissionsis set to falseScreenshot(s)
bd11-b4c7-4b9e-bd95-b709b8c2dd40.mp4
Side Effects
QA Notes