Refactor window handling, improve theme support, and update dependencies#1807
Draft
ItsEeleeya wants to merge 23 commits into
Draft
Refactor window handling, improve theme support, and update dependencies#1807ItsEeleeya wants to merge 23 commits into
ItsEeleeya wants to merge 23 commits into
Conversation
The header height now matches that of windows with Toolbars on macOS 26
…ier + fix onboarding decorations
The header height now matches that of windows with Toolbars on macOS 26
…ier + fix onboarding decorations
…a/Cap into next-base-improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a few things with small improvements here and there as a base for the upcoming PRs.
The header height on editor windows now matches that of windows with Toolbars on macOS 26.
Renamed ShowCapWindow to CapWindow.
Moved display related helper logic to
src-tauri/src/display_utils.rsof outwindows.rsRenamed AppTheme to Appearance (with serde fallback).
Re-implemented the way windows are auto shown when ready.
Fixed an issue when changing the theme back to "system" didn't properly take effect until a reload.
Use of the new
data-tauri-drag-region="deep"to prevent having to scatter it across elements.Main window is no longer a NSPanel. It still appears on the same level.
Removed the fake traffic lights.
Removed the custom AppDelegate since Tauri can position the traffic lights.
Brought back
onMouseDown={showCropOptionsMenu}within the Editor's crop section. This is the proper behavior of native menus.onClickis used as fallback for triggering it with a keyboard or touch.Bumped objc2-app-kit version.
Fake window no longer sets focus. On macOS, coupled with the
NSWindowStyleMask::NonactivatingPanelstyle mask it no longer steals focus from the active app even when clicked.(It currently does not show hover effects)