Skip to content

Add function to sketch arc given end point and radius #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spike77453 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add function to sketch arc given end point and radius #1705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion cadquery/sketch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
overload,
)

from math import tan, sin, cos, pi, radians, remainder
from math import tan, sin, cos, pi, radians, remainder, sqrt
from itertools import product, chain
from multimethod import multimethod
from typish import instance_of, get_type
Expand Down Expand Up @@ -875,6 +875,26 @@ def arc(

return self.edge(val, tag, forConstruction)

@arc.register
def arc(
self: T,
p3: Point,
r: Real,
ccw: bool = False,
tag: Optional[str] = None,
forConstruction: bool = False,
) -> T:

p1 = self._endPoint()
z = Vector(0, 0, -1) if ccw else Vector(0, 0, 1)
cord = -Vector(p1) + Vector(p3)
sagitta = r - sqrt(r ** 2 - (cord.Length / 2) ** 2)
p2 = (Vector(p1) + Vector(p3)) / 2 + sagitta * cord.cross(z).normalized()

val = Edge.makeThreePointArc(Vector(p1), Vector(p2), Vector(p3))

return self.edge(val, tag, forConstruction)

@arc.register
def arc(
self: T,
Expand Down