[FIX] Fix ownership of default Matroska track language#2193
[FIX] Fix ownership of default Matroska track language#2193Snorlax-011 wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
|
Adding a bit of context for reviewers: this PR is intentionally kept minimal. The issue is that the default language value was a string literal ( I intentionally did not keep the earlier Validated with a successful WSL/Linux build. |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 90128d8...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit e4bcade...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
This PR does not introduce any new test failures. However, some tests are failing on both master and this PR (see above). Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
Fix ownership of the default Matroska track language string in
parse_segment_track_entry().What changed
strdup("eng")LANGUAGE_IETFas stored metadata onlytrack->langWhy
langis later treated as an owned heap string and freed during cleanup, so the default"eng"value should also be heap-allocated to keep ownership consistent and avoid invalid frees.Validation