feat(rust): add --codec isdb CLI flag for ISDB/ARIB subtitle selection#2192
Open
pranavshar223 wants to merge 1 commit intoCCExtractor:masterfrom
Open
feat(rust): add --codec isdb CLI flag for ISDB/ARIB subtitle selection#2192pranavshar223 wants to merge 1 commit intoCCExtractor:masterfrom
pranavshar223 wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
Extends CCXCodec enum with Isdb variant and wires it to Codec::IsdbCc in the demuxer config, enabling users to explicitly select ISDB/ARIB subtitle streams via: --codec isdb --no-codec isdb The underlying C decoder (isdbsub_decode) and Rust Codec::IsdbCc were already present but had no CLI entry point. This change completes the wiring. Relevant for Japanese broadcast (ARIB B-24) support.
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 90128d8...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit e4bcade...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
This PR does not introduce any new test failures. However, some tests are failing on both master and this PR (see above). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends CCXCodec enum with Isdb variant and wires it to Codec::IsdbCc in the demuxer config, enabling users to explicitly select ISDB/ARIB subtitle streams via:
--codec isdb
--no-codec isdb
The underlying C decoder (isdbsub_decode) and Rust Codec::IsdbCc were already present but had no CLI
entry point. This change completes the wiring.
Relevant for Japanese broadcast (ARIB B-24) support.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
Extends
CCXCodecenum withIsdbvariant and wires it toCodec::IsdbCcin the demuxer config, enabling users to explicitlyselect ISDB/ARIB subtitle streams via:
--codec isdb
--no-codec isdb
Motivation
The underlying C decoder (
isdbsub_decode) and RustCodec::IsdbCcwere already present but had no CLI entry point. This change completes
the wiring for Japanese broadcast (ARIB B-24) support.
Testing
--codec isdbis now accepted without error--no-codec isdbcorrectly excludes the ISDB stream