Draft
Conversation
Co-authored-by: Lachlan Whyborn <lachlan.s.whyborn@gmail.com>
SeanBryan51
changed the title
SeanBryan51
changed the title
SeanBryan51
force-pushed
the
add-parallelio-output-module
branch
from
4c009fd to
b226a95
Compare
SeanBryan51
force-pushed
the
add-parallelio-output-module
branch
6 times, most recently
from
2ce7b28 to
2c76bda
Compare
This is done to allow access to private components of derived types in child submodules. See this bug report for more details: https://community.intel.com/t5/Intel-Fortran-Compiler/Intel-oneAPI-bug-with-submodules/td-p/1347530
SeanBryan51
force-pushed
the
add-parallelio-output-module
branch
from
2c76bda to
beefeab
Compare
SeanBryan51
force-pushed
the
add-parallelio-output-module
branch
from
beefeab to
0d53f58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings in a new output system based on the parallel I/O infrastructure introduced in #706, and is a direct replacement of the previous output module used for offline CABLE. This main motivation behind this is to add MPI support to the serial offline driver, and eventually, to replace the legacy MPI implementation (#358). This also makes progress towards the proposed output redesign (#715) by introducing the underlying data structures needed for its implementation.
The new output system brings in the following enhancements:
This change should be brought in after #712.
Type of change
Please delete options that are not relevant.
Checklist
Testing
Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.
Are the changes non bitwise-compatible with the main branch because of a bug fix or a feature being newly implemented or improved? If yes, add the link to the modelevaluation.org analysis versus the main branch or equivalent results below this line.
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--713.org.readthedocs.build/en/713/