Enable NAPI tests to run with locally run gltestserver#679
Open
ShahanaFarooqui wants to merge 4 commits intoBlockstream:mainfrom
Open
Enable NAPI tests to run with locally run gltestserver#679ShahanaFarooqui wants to merge 4 commits intoBlockstream:mainfrom
ShahanaFarooqui wants to merge 4 commits intoBlockstream:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the test infrastructure for the Node.js NAPI bindings to properly support running tests against a locally run
gltestserver. Previously, tests attempted to connect to remote Greenlight services. Now, tests can be run against a local regtest environment for faster, more reliable, and isolated testing.Key Changes
Limitations
connectPeercommand is not yet implemented, preventing these tests from running.onchainSenddue to timeout: TheonchainSendmethod currently hangs indefinitely, causing the related tests to time out.This PR establishes the foundational test setup required for Issue #677 by enabling Jest integration tests to run against a local gltestserver. This immediate solution allows for reliable testing while laying the groundwork for the next phase: fully integrating with the existing Python testing infrastructure (pyln.testing + gl-testing).