Draft
Conversation
justing-bq
force-pushed
the
test_build_linux
branch
from
153ddc9 to
fc15dae
Compare
justing-bq
force-pushed
the
test_build_linux
branch
from
fc15dae to
4350de9
Compare
alinaliBQ
reviewed
Mar 26, 2026
Comment on lines
401
to
405
| run: archery docker push ${{ matrix.image }} | ||
| - name: Build | ||
| run: | | ||
| ci/scripts/cpp_build.sh $(pwd) $(pwd)/build | ||
|
|
There was a problem hiding this comment.
This step needs to be removed, cpp_build.sh happens in here:
Lines 418 to 422 in 45997d2
Comment on lines
46
to
-50
| TYPED_TEST(TablesTest, SQLTablesTestInputData) { | ||
| SQLWCHAR catalog_name[] = L""; | ||
| SQLWCHAR schema_name[] = L""; | ||
| SQLWCHAR table_name[] = L""; | ||
| SQLWCHAR table_type[] = L""; |
There was a problem hiding this comment.
Is {0} same as empty string? On Linux, SQLWCHAR is same as short (an integer data type), but on macOS/Windows, SQLWCHAR is wchar_t. Not sure if it is doable assign integer to wchar_t array.
I suggest using
ASSIGN_SQLWCHAR_ARR(catalog_name, L"");
as fix
alinaliBQ
reviewed
Mar 26, 2026
| ASSIGN_SQLWCHAR_ARR(name, wstring_var) \ | ||
| size_t name##_len = std::wcslen(reinterpret_cast<const wchar_t*>(name)); | ||
| #else | ||
| # define ASSIGN_SQLWCHAR_ARR(name, wstring_var) SQLWCHAR name[] = wstring_var; |
There was a problem hiding this comment.
Maybe this works
Suggested change
| # define ASSIGN_SQLWCHAR_ARR(name, wstring_var) SQLWCHAR name[] = wstring_var; | |
| # define ASSIGN_SQLWCHAR_ARR(name, wstring_var) SQLWCHAR* name = wstring_var; |
alinaliBQ
reviewed
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?