Merged
Conversation
…ks them Add internal/defaults package that embeds public/index.html, public/404.html, and public/style.css into the binary via //go:embed. Update FileHandler to fall back to these embedded assets when the configured files.root does not contain the requested file, ensuring sensible default pages are always available regardless of deployment layout.
Cover five scenarios: embedded index.html served when root is empty, embedded style.css with correct content-type, embedded 404.html served by serveNotFound when no custom page is configured, sub-path URLs correctly bypassing the embed fallback, and custom not_found config taking priority over the embedded 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.