Skip to content

Fix WebSocket polyfill spec compliance and test flake #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bghgary wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix WebSocket polyfill spec compliance and test flake #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2972c95
Fix WebSocket test double-done flake
bghgary Apr 8, 2026
0310406
Fix inconsistent WebSocket capitalization in error messages
bghgary Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions Tests/UnitTests/Scripts/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,14 +408,22 @@ if (hostPlatform !== "Unix") {
it("should connect correctly with one websocket connection", function (done) {
const ws = new WebSocket("wss://ws.postman-echo.com/raw");
const testMessage = "testMessage";
let finished = false;
const finish = (err?: Error) => {
if (!finished) {
finished = true;
done(err);
}
};

ws.onopen = () => {
try {
expect(ws).to.have.property("readyState", 1);
expect(ws).to.have.property("url", "wss://ws.postman-echo.com/raw");
ws.send(testMessage);
}
catch (e) {
done(e);
finish(e as Error);
}
};

Expand All @@ -425,28 +433,35 @@ if (hostPlatform !== "Unix") {
ws.close();
}
catch (e) {
done(e);
finish(e as Error);
}
};

ws.onclose = () => {
try {
expect(ws).to.have.property("readyState", 3);
done();
finish();
}
catch (e) {
done(e);
finish(e as Error);
}
};

ws.onerror = (ev) => {
done(new Error("WebSocket failed"));
finish(new Error("WebSocket failed"));
};
});

it("should connect correctly with multiple websocket connections", function (done) {
const testMessage1 = "testMessage1";
const testMessage2 = "testMessage2";
let finished = false;
const finish = (err?: Error) => {
if (!finished) {
finished = true;
done(err);
}
};

const ws1 = new WebSocket("wss://ws.postman-echo.com/raw");
ws1.onopen = () => {
Expand All @@ -458,7 +473,7 @@ if (hostPlatform !== "Unix") {
ws2.send(testMessage2);
}
catch (e) {
done(e);
finish(e as Error);
}
};

Expand All @@ -468,7 +483,7 @@ if (hostPlatform !== "Unix") {
ws2.close();
}
catch (e) {
done(e);
finish(e as Error);
}
};

Expand All @@ -478,12 +493,12 @@ if (hostPlatform !== "Unix") {
ws1.send(testMessage1);
}
catch (e) {
done(e);
finish(e as Error);
}
};

ws2.onerror = (ev) => {
done(new Error("Websocket failed"));
finish(new Error("WebSocket failed"));
};
}

Expand All @@ -493,22 +508,22 @@ if (hostPlatform !== "Unix") {
ws1.close();
}
catch (e) {
done(e);
finish(e as Error);
}
}

ws1.onclose = () => {
try {
expect(ws1).to.have.property("readyState", 3);
done();
finish();
}
catch (e) {
done(e);
finish(e as Error);
}
}

ws1.onerror = (ev) => {
done(new Error("Websocket failed"));
finish(new Error("WebSocket failed"));
};
});

Expand Down
Loading