Merge WorkQueue into AppRuntime

[bghgary]

Merge WorkQueue into AppRuntime to eliminate split-lifetime issues.

Motivation

WorkQueue was a separate class with its own thread, dispatcher, and cancel source. AppRuntime captured this in lambdas passed to WorkQueue, creating split-lifetime issues where the worker thread could access partially-destroyed AppRuntime members during shutdown.

Changes

• Thread, dispatcher, cancel source, env, and suspension lock are now direct AppRuntime members
• Destruction order is deterministic (no cross-object lifetime issues)
• WorkQueue.h and WorkQueue.cpp removed
• AppRuntime_JSI.cpp: TaskRunnerAdapter now uses AppRuntime::Dispatch instead of WorkQueue::Append, and uses std::move(task) instead of task.release() for shared_ptr construction

Behavioral note

JSI tasks now route through Dispatch, which wraps them in the Execute/exception-handler. Previously, uncaught exceptions from JSI tasks would crash the process. They are now handled by UnhandledExceptionHandler like all other dispatched work.

The deadlock fix from #147 is preserved.

[Copilot]

Pull request overview

This PR refactors the AppRuntime threading model by inlining the former WorkQueue implementation into AppRuntime, aiming to eliminate split-lifetime shutdown hazards caused by cross-object thread/dispatcher ownership.

Changes:

• Removed the WorkQueue class/files and moved its thread, dispatcher, cancellation source, env tracking, and suspension lock into AppRuntime.
• Updated AppRuntime to manage the worker thread lifecycle directly (including the deadlock-avoidance “cancel + enqueue no-op” wake-up).
• Updated the JSI task runner adapter to post tasks via AppRuntime::Dispatch and modernized shared ownership creation for tasks.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Core/AppRuntime/Source/WorkQueue.h	Removed (WorkQueue API eliminated).
Core/AppRuntime/Source/WorkQueue.cpp	Removed (WorkQueue implementation merged into AppRuntime).
Core/AppRuntime/Source/AppRuntime.cpp	Moved WorkQueue run-loop/suspend/resume/shutdown logic into AppRuntime and starts the worker thread directly.
Core/AppRuntime/Source/AppRuntime_JSI.cpp	TaskRunnerAdapter now targets AppRuntime instead of WorkQueue; task ownership construction updated.
Core/AppRuntime/Include/Babylon/AppRuntime.h	Added dispatcher/cancellation/thread members and an internal Append helper.
Core/AppRuntime/CMakeLists.txt	Removed WorkQueue sources from the AppRuntime target.

Comments suppressed due to low confidence (1)

Core/AppRuntime/Source/AppRuntime.cpp:17

• The worker thread is started in the member initializer list. If any code in the constructor body throws after m_thread is created (e.g., Dispatch(...) or allocations inside it), stack unwinding will destroy m_thread while it is still joinable, which will call std::terminate because AppRuntime’s destructor is not run for a partially-constructed object. Consider starting the thread after all potentially-throwing constructor work (or using a scope guard/RAII thread wrapper that joins on unwind).

    AppRuntime::AppRuntime(Options options)
        : m_options{std::move(options)}
        , m_thread{[this] { RunPlatformTier(); }}
    {
        Dispatch([this](Napi::Env env) {
            JsRuntime::CreateForJavaScript(env, [this](auto func) { Dispatch(std::move(func)); });
        });

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.