[Python] TypeSpec migration for azure-mgmt-databoxedge#47110
Draft
msyyc wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeSpec Migration:
azure-mgmt-databoxedgeSpec source
2023-12-01(default tag:package-2023-12-01)2023-12-01(matched from swagger default tag)Classification summary
@@clientName)Mitigations applied in spec PR
MetricDimension_V1→ renamed back toMetricDimensionV1(Rule 13)MetricSpecification_V1→ renamed back toMetricSpecificationV1(Rule 13)Accepted breaking changes (no mitigation)
Rule 7 — Removal of Unreferenced Models:
DataBoxEdgeMoveRequestRule 8 — Removal of Pageable List Models:
AddonList,AlertList,BandwidthSchedulesList,ContainerList,DataBoxEdgeDeviceList,DataBoxEdgeSkuList,MonitoringMetricConfigurationList,NodeList,OperationsList,OrderList,RoleList,ShareList,StorageAccountCredentialList,StorageAccountList,TriggerList,UserListRule 9 — Parameters Changed to Keyword-only:
DeviceCapacityCheckOperations.begin_check_resource_creation_feasibility(capacity_name)DevicesOperations.list_by_resource_group(expand)DevicesOperations.list_by_subscription(expand)Rule 11 — Removal of multi-level flattened properties (new
propertiesbag exposes the REST structure):DCAccessCode.auth_codeDataBoxEdgeDevicePatch.edge_profileDeviceCapacityRequestInfo.vm_placement_query,vm_placement_resultsDiagnosticProactiveLogCollectionSettings.user_consentEdgeProfileSubscription.tenant_id,location_placement_id,quota_id,serialized_details,registered_featuresFileEventTrigger.source_info,sink_info,custom_context_tagPeriodicTimerEventTrigger.source_info,sink_info,custom_context_tagTriggerSupportPackageRequest.minimum_time_stamp,maximum_time_stamp,includeUploadCertificateRequest.authentication_type,certificateChangelog consolidation
MetricDimensionV1→MetricDimension_V1(consolidated; same wire fields)MetricSpecificationV1→MetricSpecification_V1(consolidated; same wire fields)*Listdeletions remain (pageable wrappers; no rename target).DataBoxEdgeMoveRequest: no replacement model in new spec — kept as deletion.