Generate from latest spec and deleteAgent customizations

[kaylieee]

This pull request refactors the agent deletion functionality in the Azure AI Agents SDK. The main change is the internalization and renaming of delete agent methods and models, moving them from public-facing APIs to internal implementation. This update clarifies the SDK's public API surface and improves internal structure, without changing the external behavior for most users.

Key changes:

API Refactoring and Internalization:

• The DeleteAgentResponse model has been moved from com.azure.ai.agents.models to com.azure.ai.agents.implementation.models, making it internal to the SDK. All references in the client classes have been updated accordingly. [1] [2] [3]
• The public deleteAgentWithResponse and deleteAgent methods that returned a DeleteAgentResponse object have been removed from both AgentsClient and AgentsAsyncClient. Instead, new internal methods (internalDeleteAgentWithResponse, internalDeleteAgent) are introduced for internal use, and the public deleteAgent method is now void (sync) or returns Mono<Void> (async). [1] [2] [3] [4] [5] [6]

Service Implementation Changes:

• The service interface and its implementation have renamed the delete agent methods from deleteAgent to internalDeleteAgent to reflect their new internal status. [1] [2]
• The implementation methods in AgentsImpl have been updated to use these new internal names, and the corresponding service calls have been updated to match. [1] [2]

Minor Import and Utility Updates:

• Unused imports of the now-internal DeleteAgentResponse model have been removed from client files and replaced with the new internal import where necessary. [1] [2]
• Minor utility imports have been added in other implementation files to support these changes.

These changes help clarify which parts of the agent deletion API are intended for public use and which are for internal SDK operations, improving maintainability and reducing the risk of accidental misuse by SDK consumers.

[Copilot]

Pull request overview

This PR updates the generated Azure AI Agents SDK to the latest REST API spec revision and refactors “delete agent” so the response model and response-returning methods are no longer part of the public API surface.

Changes:

• Bumps the TypeSpec source commit used for generation.
• Moves DeleteAgentResponse to com.azure.ai.agents.implementation.models and replaces the public delete APIs with void / Mono<Void> public methods plus internal response-returning variants.
• Renames the underlying service-layer delete methods to internalDeleteAgent* to reflect internal usage.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
sdk/ai/azure-ai-agents/tsp-location.yaml	Updates the spec commit used for code generation.
sdk/ai/azure-ai-agents/src/main/resources/META-INF/azure-ai-agents_metadata.json	Updates cross-language mappings and generated file inventory after regeneration/refactor.
sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/models/LocalShellExecAction.java	Changes timeout_ms handling to use Duration and ISO-8601 string serialization.
sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/models/DeleteAgentResponse.java	Internalizes the delete-agent response model by moving it under implementation.models.
sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/AgentsImpl.java	Renames service delete methods to internalDeleteAgent* and updates call sites.
sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/AgentsClient.java	Removes public response-returning delete methods and introduces void deleteAgent(...) plus internal variants.
sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/AgentsAsyncClient.java	Removes public response-returning delete methods and introduces Mono<Void> deleteAgent(...) plus internal variants.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

timeout_ms is documented as a millisecond timeout and other models (e.g., FunctionShellActionParam) serialize/deserialize it as a JSON number, but LocalShellExecAction now serializes it as an ISO-8601 duration string and deserializes using Duration.parse(reader.getString()). This will fail if the service sends a numeric timeout_ms (or if callers send numeric JSON), and it also makes the wire shape inconsistent. Consider keeping timeout_ms as a numeric millisecond value (e.g., Long) or, if the spec truly changed to a duration string, update all related models and rename/document the property accordingly (and handle both number/string formats for backward compatibility).

Suggested change

	duration = reader.getNullable(nonNullReader -> Duration.parse(nonNullReader.getString()));
	duration = reader.getNullable(nonNullReader -> {
	JsonToken token = nonNullReader.currentToken();
	if (token == JsonToken.NUMBER) {
	long timeoutMillis = nonNullReader.getLong();
	return Duration.ofMillis(timeoutMillis);
	} else if (token == JsonToken.STRING) {
	return Duration.parse(nonNullReader.getString());
	} else {
	nonNullReader.skipChildren();
	return null;
	}
	});

[jpalvarezl]

This comment actually makes sense. Let's sync today with other languages as to what is the format for this. Not sure if it's easy enough to try hitting the live service with a unit tests covering this. That would be the best way to solve this and determine the right way forward.

[Copilot]

azure-ai-agents_metadata.json still lists src/main/java/com/azure/ai/agents/models/DeleteAgentResponse.java in generatedFiles, but DeleteAgentResponse has been moved under com/azure/ai/agents/implementation/models and there is no models/DeleteAgentResponse.java file anymore. This mismatch can break tooling that relies on generatedFiles being accurate; update the metadata to remove the old path and keep only the current generated file location.

[Copilot]

This API change (making AgentsClient.deleteAgent return void and removing DeleteAgentResponse from the public models package) breaks in-repo usages that still expect DeleteAgentResponse (for example the DeleteAgent sample and AgentsTests). Those call sites need to be updated to call deleteAgent(...) without capturing a return value (and to stop importing com.azure.ai.agents.models.DeleteAgentResponse).

[Copilot]

deleteAgent currently calls internalDeleteAgent(agentName) and discards the returned DeleteAgentResponse, which still forces a JSON-to-object deserialization. Since the public method is intentionally void, consider delegating to internalDeleteAgentWithResponse(...) (or the underlying impl method that returns Response<BinaryData>) and ignoring the body to avoid unnecessary deserialization work and avoid coupling the public method to the response schema.

Suggested change

	internalDeleteAgent(agentName);
	RequestOptions requestOptions = new RequestOptions();
	internalDeleteAgentWithResponse(agentName, requestOptions);

[Copilot]

AgentsAsyncClient.deleteAgent delegates to internalDeleteAgent(agentName).then(), which still deserializes the delete response into DeleteAgentResponse even though the public API returns Mono<Void>. To reduce overhead and avoid coupling to the response body, consider delegating to internalDeleteAgentWithResponse(agentName, requestOptions).then() (or otherwise avoiding the toObject(DeleteAgentResponse.class) step).

Suggested change

	return internalDeleteAgent(agentName).then();
	RequestOptions requestOptions = new RequestOptions();
	return internalDeleteAgentWithResponse(agentName, requestOptions).then();

[jpalvarezl]

We should check if other languages have tests that somehow cover LocalShellExecAction and reproduce to confirm that we are still deserializing correctly. Otherwise, we can manually try producing JSON where the duration is represented as String and number and see what happens.