Skip to content

Separate MCP app and Weather app#40

Merged
lilyjma merged 7 commits intomainfrom
hallvictoria/separate-apps
Apr 4, 2026
Merged

Separate MCP app and Weather app#40
lilyjma merged 7 commits intomainfrom
hallvictoria/separate-apps

Conversation

@hallvictoria
Copy link
Copy Markdown
Contributor

Purpose

  • Separates MCP app and Weather app
  • Updates host.json for GA bundle

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably delete this app directory right? I'm assuming it's the same was the one inside McpWeatherApp

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this is auto generated when you do npm run build. Can we make the auto generated folder go under the McpWeatherApp folder or does that not make sense?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the src/app directory is deleted. There is only an app directory under McpWeatherApp.

package-lock.json will be auto-generated and added to McpWeatherApp/app when the customer runs npm run build.

@lilyjma
Copy link
Copy Markdown
Collaborator

lilyjma commented Apr 1, 2026

@hallvictoria - Could you add an app-level readme inside McpWeatherApp? You can move the instructions today in the main readme to the app's readme. Probably need to update it as well, like calling out the Python version needed. I ran into error because I wasn't using the right version.

@lilyjma
Copy link
Copy Markdown
Collaborator

lilyjma commented Apr 1, 2026

I'm also seeing the __pycache__ directory inside src. GitIgnore has it but maybe because it's at the root so still not ignored? We should find a way to ignore it though.

@hallvictoria
Copy link
Copy Markdown
Contributor Author

__pycache__ is not included in this PR - are you seeing it locally?

@lilyjma
Copy link
Copy Markdown
Collaborator

lilyjma commented Apr 4, 2026

__pycache__ is not included in this PR - are you seeing it locally?

My mistake - I saw it locally so I thought it was pulled in as part of the PR.

@lilyjma
Copy link
Copy Markdown
Collaborator

lilyjma commented Apr 4, 2026

Thanks for making the changes! I pushed a few changes in the README - there's an extra step the user needs to do to specify which project to deploy. I asked copilot to deploying based on the new instructions and both servers deploy fine and work!

I'm going to merge this PR.

Btw, do we still need the pyproject.toml? seems like we're just relying on requirements.txt inside the projects?

@lilyjma lilyjma merged commit 3aced0a into main Apr 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants