Conversation
src/app/package-lock.json
Outdated
There was a problem hiding this comment.
we should probably delete this app directory right? I'm assuming it's the same was the one inside McpWeatherApp
There was a problem hiding this comment.
actually this is auto generated when you do npm run build. Can we make the auto generated folder go under the McpWeatherApp folder or does that not make sense?
There was a problem hiding this comment.
Yes, the src/app directory is deleted. There is only an app directory under McpWeatherApp.
package-lock.json will be auto-generated and added to McpWeatherApp/app when the customer runs npm run build.
|
@hallvictoria - Could you add an app-level readme inside |
|
I'm also seeing the |
…nctions-python into hallvictoria/separate-apps
|
|
My mistake - I saw it locally so I thought it was pulled in as part of the PR. |
|
Thanks for making the changes! I pushed a few changes in the README - there's an extra step the user needs to do to specify which project to deploy. I asked copilot to deploying based on the new instructions and both servers deploy fine and work! I'm going to merge this PR. Btw, do we still need the pyproject.toml? seems like we're just relying on requirements.txt inside the projects? |
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information