Fix CODESYS XML export namespace for variable documentation#722
Fix CODESYS XML export namespace for variable documentation#722manux81 wants to merge 6 commits into
Conversation
WalkthroughAdded the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/PLC/xml-generator/xml-generator-initial-values.spec.ts`:
- Line 24: The test fixtures use four `as any` casts which suppress TypeScript
checks; replace each `as any` with a proper `satisfies` assertion against the
corresponding Zod-backed types (e.g. use `... satisfies PLCPou`, `... satisfies
PLCConfiguration`, or `... satisfies BaseXml` as appropriate for each fixture)
so the static shape is validated without widening to `any`; update the four
occurrences currently cast to `as any` to use `satisfies <Type>` matching the
fixture intent and ensure imports/references to `PLCPou`, `PLCConfiguration`,
and `BaseXml` are present for the assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 07fd32b1-848b-40d1-b416-70a4eaf9b639
📒 Files selected for processing (3)
src/types/PLC/xml-data/codesys/base-diagram.tssrc/utils/PLC/xml-generator/codesys/base-xml.tssrc/utils/PLC/xml-generator/xml-generator-initial-values.spec.ts
Pull request info
References
If applicable substitute the issue reference to the one that this PR refers
This PR resolve the N/A.
Link to Jira task
N/A
Description of the changes proposed
xhtmlnamespace in generated CODESYS PLCopen XML documentsdevelopmentDOD checklist