[codex] Bound COW e2e CI runtime#213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds
timeout-minutes: 45to the full Linux COW e2e step and the macOS APFS sparsebundle e2e step.Rationale
The Intel mac APFS e2e can legitimately be much slower than Apple Silicon; today it took
31m5s. Without a step timeout, an APFS/server teardown hang can consume the whole job instead of failing with a bounded, actionable signal.Implementation
Only
.github/workflows/ci.ymlchanges. The sametests/cow/e2e.shcommands still run with the same environment.Testing instructions
git diff --check origin/trunk...HEAD