fix: warn before closing when any tab is unsaved#206
Merged
LarryZhu-dev merged 1 commit intoAuto-Plugin:mainfrom May 3, 2026
Merged
Conversation
Contributor
|
Hi,感谢你的贡献,我正在休假,可能会在稍晚查看此请求。 |
maqibg
pushed a commit
to maqibg/milkup
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The window close guard was using the active tab's modified state as the saved/unsaved signal for the whole BrowserWindow. Switching from an edited markdown tab to a saved tab could mark the window as saved, so closing skipped the existing save confirmation flow.
The save-state watcher now reports whether any tab in the window is modified, keeping the main-process window state dirty until all tabs are saved or discarded.
Verification:
pnpm run buildpnpm exec oxlint src/renderer/hooks/useContent.ts && pnpm exec oxfmt --check src/renderer/hooks/useContent.tsFixes #200