Skip to content

Fix DM reactions popup drifting off-screen on scroll#14020

Draft
cursor[bot] wants to merge 1 commit intomainfrom
cursor/bug-report-resolution-729b
Draft

Fix DM reactions popup drifting off-screen on scroll#14020
cursor[bot] wants to merge 1 commit intomainfrom
cursor/bug-report-resolution-729b

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor bot commented Mar 27, 2026

Summary

  • Fixes a UI positioning bug where the DM reactions popup could drift upward/off-screen after opening.
  • Updates Harmony popup scroll tracking to clamp computed top position to viewport bounds when auto-flip/clamping is enabled.

Root Cause

  • Popup initially clamps its position when opened, but the scroll listener later recomputed top without clamping.
  • In scrollable chat containers this allowed the popup to keep moving upward and leave the viewport.

Changes

  • packages/harmony/src/components/popup/Popup.tsx
    • In watchScroll, compute nextTop and clamp to [0, window.innerHeight - popupHeight] unless disableAutoFlip is enabled.
    • Add disableAutoFlip to callback deps.

Validation

  • Manual code-path validation of popup positioning logic.
  • Attempted targeted lint command, but local workspace tools were unavailable (eslint: not found) in this environment.
Open in Web View Automation 

Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

⚠️ No Changeset found

Latest commit: eddc275

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14020.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant