Skip to content

Handle already-processed reward claim responses #13966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Handle already-processed reward claim responses #13966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions packages/web/src/common/store/pages/audio-rewards/sagas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import {
SpecifierWithAmount,
Name,
Feature,
ChallengeName
ChallengeName,
FailureReason
} from '@audius/common/models'
import {
IntKeys,
Expand Down Expand Up @@ -221,6 +222,14 @@ type ErrorResult = SpecifierWithAmount & {
error: unknown
}

const isAlreadyClaimedErrorMessage = (errorMessage: string) => {
const normalizedError = errorMessage.toUpperCase()
return (
normalizedError.includes(FailureReason.ALREADY_DISBURSED) ||
normalizedError.includes(FailureReason.ALREADY_SENT)
)
}

async function claimRewardsForChallenge({
sdk,
userId,
Expand Down Expand Up @@ -256,8 +265,14 @@ async function claimRewardsForChallenge({
})
)
.then((res) => {
if (res?.data?.[0]?.error) {
throw new Error(res.data[0].error)
const claimError = res?.data?.[0]?.error
if (claimError && !isAlreadyClaimedErrorMessage(claimError)) {
throw new Error(claimError)
}
// ALREADY_DISBURSED/ALREADY_SENT means the reward was already
// processed; treat it as a successful outcome for client state.
if (claimError) {
return res
}
track(
make({
Expand Down
Loading