fix: clean leftover merge conflict markers on dev#7203
Closed
zhuanggenhua wants to merge 3 commits intoAstrBotDevs:devfrom
Closed
fix: clean leftover merge conflict markers on dev#7203zhuanggenhua wants to merge 3 commits intoAstrBotDevs:devfrom
zhuanggenhua wants to merge 3 commits intoAstrBotDevs:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes merge conflict markers and redundant code from gemini_source.py and server.py. It specifically cleans up duplicate method definitions and logic related to SSL configuration in the dashboard server. I have no feedback to provide.
Author
|
Closing this PR because it was created against the wrong project during an assistant context-mixup. We will restart from the correct tabletop project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev 分支残留冲突修复留案(2026-03-30)
背景
dev分支的检查失败,表现为Unit Tests与Smoke Test在 Python import 阶段直接报SyntaxError。astrbot/dashboard/server.py与astrbot/core/provider/sources/gemini_source.py中存在残留的 Git conflict markers。受影响文件
astrbot/dashboard/server.pyastrbot/core/provider/sources/gemini_source.py冲突来源定位
dev分支头包含残留冲突标记。efa999c2:merge: origin/master into dev1faeee37:merge: pull latest master into devserver.py不只是残留标记,还混入了重复run()、同步/异步签名错位、await位置错误等二次损伤。合并原则
文件一:
astrbot/core/provider/sources/gemini_source.py冲突形态
candidate.content为空分支前残留<<<<<<< HEADcandidate.content.parts为空分支前残留<<<<<<< HEAD两侧逻辑对比
EmptyModelOutputError,错误语义更清晰。最终合并结果
EmptyModelOutputError分支处理。合并理由
文件二:
astrbot/dashboard/server.py冲突形态
<<<<<<< HEAD/>>>>>>> origin/masterrun()实现def run(self)与异步async def run(self)混杂await serve(...)落在同步函数上下文中两侧逻辑对比
dev 侧(旧 async 版本)保留的能力
async def run(self)+await serve(...)_build_bind()WebUI + API/API Server两种启动提示host与127.0.0.1检查_print_access_urls()统一输出本地/网络访问地址_resolve_dashboard_value()支持配置值中的环境变量占位符master 侧(被 merge 进来的版本)新增/增强的能力
_resolve_dashboard_ssl_config()把 SSL 文件校验抽成独立方法DASHBOARD_SSL_*/ASTRBOT_DASHBOARD_SSL_*这类更明确的环境变量命名最终合并结果
本次不再简单回滚为 dev 侧,而是采用合并版:
_resolve_dashboard_ssl_config()思路;DASHBOARD_SSL_*ASTRBOT_DASHBOARD_SSL_*ASTRBOT_SSL_*_resolve_dashboard_value(),确保 SSL 路径仍支持占位符展开;run()中不再手写三段证书路径解析,而是调用统一 helper 生成resolved_ssl_config;ssl_enable读取兼容:DASHBOARD_SSL_ENABLEASTRBOT_DASHBOARD_SSL_ENABLEASTRBOT_SSL_ENABLE合并理由
验证
已完成
python -m py_compile astrbot/dashboard/server.py astrbot/core/provider/sources/gemini_source.py待补充
Unit TestsSmoke Test的实际结果
uv run ruff format .uv run ruff check .PR / 分支信息
fix/dev-merge-conflict-cleanup#7203后续动作