fix(ltm): Retain per-user contexts when enabling dialogue isolation#7179
Closed
Reisenbug wants to merge 2 commits intoAstrBotDevs:masterfrom
Closed
fix(ltm): Retain per-user contexts when enabling dialogue isolation#7179Reisenbug wants to merge 2 commits intoAstrBotDevs:masterfrom
Reisenbug wants to merge 2 commits intoAstrBotDevs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a unique_session configuration to conditionally prevent clearing request contexts when active reply is enabled. However, the current implementation incorrectly attempts to retrieve this setting from a processed configuration object that lacks the required key, making the feature non-functional. A suggestion was provided to correctly access the configuration via the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
开启群聊上下文感知的主动回复时,on_req_llm 会无条件执行 req.contexts = [], 导致对话隔离(unique_session)维护的 per-user 对话历史被清空,对话隔离无效
Modifications / 改动点
astrbot/builtin_stars/astrbot/long_term_memory.py: 仅在 unique_session 未开启时清空 req.contexts。开启时保留 per-user contexts,使其与群聊上下文背景并存。逻辑错误,无报错日志。可通过在 on_req_llm 执行前后打印 req.contexts 验证:unique_session 开启时执行后 contexts 不再被清空
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: