LiteRT: Native-Bibliothek vor Gemma‑4-Engine laden#77
Open
Android-PowerUser wants to merge 10 commits intoadd-gemma-4-e4b-it-integration-neat1yfrom
Open
LiteRT: Native-Bibliothek vor Gemma‑4-Engine laden#77Android-PowerUser wants to merge 10 commits intoadd-gemma-4-e4b-it-integration-neat1yfrom
Android-PowerUser wants to merge 10 commits intoadd-gemma-4-e4b-it-integration-neat1yfrom
Conversation
Contributor
There was a problem hiding this comment.
The changes correctly address the JNI loading issue for the Gemma 4 offline model by ensuring the LiteRT native library is loaded before engine initialization. The implementation follows best practices with proper state tracking, error handling via runCatching, and a fallback mechanism.
Key improvements:
- Added
NativeLibraryLoaderimport and state flag - Implemented
ensureLiteRtNativeLoaded()with primary load viaNativeLibraryLoader.INSTANCE.load()and fallback toSystem.loadLibrary() - Called before
Engine(engineConfig).initialize()to prevent JNI errors
The code is well-structured and should resolve the "No implementation found" error mentioned in the PR description.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nativeCheckLoaded/ "No implementation found ...") auf; diese Änderung stellt sicher, dass die LiteRT-JNI-Bibliothek geladen ist, bevor die Engine initialisiert wird.Description
NativeLibraryLoader, ergänzt das FlagliteRtNativeLoadedund fügtensureLiteRtNativeLoaded()hinzu, dasNativeLibraryLoader.INSTANCE.load()aufruft und bei Fehlschlag als FallbackSystem.loadLibrary("litertlm_jni")verwendet, und ruft diese Funktion vorEngine(engineConfig).initialize()auf.Testing
./gradlew :app:lintDebugund./gradlew :app:assembleDebugwurden ausgeführt und schlugen fehl wegen fehlender Android SDK-Konfiguration (SDK location not found), daher konnten die Builds in dieser Umgebung nicht erfolgreich abgeschlossen werden.Codex Task