Merged
Conversation
This is the first move toward having all time measurements in nanoseconds.
Only report I/O speeds when flag --destructive is used because the safe device disrupts the measurements.
This commit makes f3write, f3read, f3brew report I/O speeds analogously to f3probe: 1. Emphasizing that these are *sequential* measurements. 2. Including the number of blocks and time measured. 3. Using "write" and "read" instead of "writing" and "reading".
AltraMayor
force-pushed
the
probe_speeds
branch
from
9084c18 to
d644d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves
f3probeto report I/O speeds in the final probe report when the flag--destructiveis used, and in the--verboseoutput.f3proberequires the flag--destructiveto report I/O speeds in the final probe report because the safe device disrupts the measurements. I/O speeds are always present in the--verboseoutput because it is meant to support diagnoses and to give users the option to follow the probe.In addition, this pull request adds parameters
--max-read-rateand--max-write-ratetof3probe. These parameters are meant to enable users to probe drives that overheat under maximum read and write rates. Fortunately, this is a rare use case nowadays.Finally, this pull request standardizes the report of I/O speeds in line with
f3probeforf3read,f3write, andf3brew. Meaning that these reports emphasize sequential measurements (i.e., no random reads or writes), include the number of blocks and the measured time, and use "read" and "write" instead of "writing" and "reading".