Skip to content

[QC-1346] Scaffolding to share common code among QC data processors #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knopers8 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[QC-1346] Scaffolding to share common code among QC data processors #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3f04c2
QC-1346 Scaffolding to share common code among QC data processors
knopers8 Apr 1, 2026
ed7fe8c
keep clang happy even though I don't believe it's right
knopers8 Apr 2, 2026
4d8662b
Assume "resilient" for critical data processors with uncertain upstream
knopers8 Apr 2, 2026
42a5bf3
Move correct inheritance check to happen after the type is fully known
knopers8 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Framework/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ add_library(O2QualityControl
src/QCInputsAdapters.cxx
src/QCInputsFactory.cxx
src/UserInputOutput.cxx
src/Actor.cxx
src/ActorHelpers.cxx
src/DataProcessorAdapter.cxx
)

target_include_directories(
Expand Down Expand Up @@ -270,12 +273,16 @@ endforeach()
add_executable(o2-qc-test-core
test/testActivity.cxx
test/testActivityHelpers.cxx
test/testActorHelpers.cxx
test/testActorTraits.cxx
test/testActor.cxx
test/testAggregatorInterface.cxx
test/testAggregatorRunner.cxx
test/testCheck.cxx
test/testCheckInterface.cxx
test/testCheckRunner.cxx
test/testCustomParameters.cxx
test/testDataProcessorAdapter.cxx
test/testDataHeaderHelpers.cxx
test/testInfrastructureGenerator.cxx
test/testMonitorObject.cxx
Expand All @@ -295,6 +302,7 @@ add_executable(o2-qc-test-core
test/testQualitiesToFlagCollectionConverter.cxx
test/testQCInputs.cxx
test/testUserInputOutput.cxx
test/testStringUtils.cxx
)
set_property(TARGET o2-qc-test-core
PROPERTY RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/tests)
Expand All @@ -310,6 +318,7 @@ target_include_directories(o2-qc-test-core PRIVATE ${CMAKE_SOURCE_DIR})
target_include_directories(o2-qc-test-core PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>)

set(TEST_SRCS
test/testActorCallbacks.cxx
test/testDbFactory.cxx
test/testPublisher.cxx
test/testQcInfoLogger.cxx
Expand All @@ -325,12 +334,12 @@ set(TEST_SRCS
test/testWorkflow.cxx
test/testRepoPathUtils.cxx
test/testUserCodeInterface.cxx
test/testStringUtils.cxx
test/testRunnerUtils.cxx
test/testBookkeepingQualitySink.cxx
)

set(TEST_ARGS
"-b --run"
""
""
""
Expand Down Expand Up @@ -380,6 +389,8 @@ endforeach()

target_include_directories(testCcdbDatabase PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>)

set_property(TEST testActorCallbacks PROPERTY TIMEOUT 30)
set_property(TEST testActorCallbacks PROPERTY LABELS slow)
set_property(TEST testWorkflow PROPERTY TIMEOUT 40)
set_property(TEST testWorkflow PROPERTY LABELS slow)
set_property(TEST testCheckWorkflow PROPERTY TIMEOUT 50)
Expand Down
Loading
Loading