Skip to content

TPC QC: update json configs #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wiechula merged 2 commits into from
Jul 8, 2025
Merged

TPC QC: update json configs #2557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e699083
Feat: update json configs
ariedel-cern May 21, 2025
5609d2b
Fix: fix config files
ariedel-cern May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Modules/TPC/run/tpcQCRawDigitVisualizer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@
{ "N_Clusters" : [ "100", "0", "100" ] },
{ "N_RawDigits" : [ "100", "0", "100" ] },
{ "Q_Max" : [ "200", "0", "200" ] },
{ "Time_Bin" : [ "1000", "0", "100000" ] }
{ "Time_Bin" : [ "1000", "0", "100000" ] },
{ "Occupancy" : [ "100", "0", "0.001" ] }
],
"path_comment": "This is the path of the RawDigitData object that shall be visualized.",
"path": "TPC/MO/RawDigits/RawDigitData",
"path": "qc/TPC/MO/RawDigits/RawDigitData",
"dataType_comment": "This is the switch for 'RawDigits' or 'Clusters' task. Choose 'raw' or 'clusters'.",
"dataType": "raw",
"initTrigger": [
Expand Down
3 changes: 2 additions & 1 deletion Modules/TPC/run/tpcQCRawDigits_direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"mergeableOutput": "true",
"NRawDigitsNBins": "100", "NRawDigitsXMin": "0", "NRawDigitsXMax": "100",
"QmaxNBins": "200", "QmaxXMin": "0", "QmaxXMax": "200",
"TimeBinNBins": "1000", "TimeBinXMin": "0", "TimeBinXMax": "100000"
"TimeBinNBins": "1000", "TimeBinXMin": "0", "TimeBinXMax": "100000",
"OccupancyNBins": "1000", "OccupancyXMin": "0", "OccupancyXMax": "100000"
Copy link
Copy Markdown
Collaborator

@wiechula wiechula May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't occupancy be between 0 and 1?

Copy link
Copy Markdown
Contributor Author

@ariedel-cern ariedel-cern May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I updated also the files to set as max 1

},
"location": "local",
"localMachines": [
Expand Down