[PWGCF] process NUA Creator added#15029
Merged
victor-gonzalez merged 3 commits intoAliceO2Group:masterfrom Feb 19, 2026
Merged
Conversation
nmallick19
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
[PWGCF] Please consider the following formatting changes to AliceO2Group#15029
Contributor
|
Looks good from my point of view, no contradictions with our development |
jaelpark
reviewed
Feb 19, 2026
| // NUA corrections are a function of multiplicity, partType, phi, eta, and z-vertex | ||
| const double nuaCoords[] = {collision.multiplicity(), static_cast<double>(partType), track.phi(), track.eta(), collision.posZ()}; | ||
| phiWeight = ph->GetBinContent(ph->GetBin(nuaCoords)); | ||
| phiWeight = phiWeight == 0. ? 1.0f : phiWeight; // avoid division by zero later |
Collaborator
There was a problem hiding this comment.
Small change to account for possible numeric rounding issues
Suggested change
| phiWeight = phiWeight == 0. ? 1.0f : phiWeight; // avoid division by zero later | |
| if (phiWeight < 1e-6f) | |
| phiWeight = 1.0f; // avoid division by zero later |
Collaborator
There was a problem hiding this comment.
It's not a requirement though since the tests have mostly run already.
victor-gonzalez
approved these changes
Feb 19, 2026
comrademarvin
pushed a commit
to comrademarvin/O2Physics
that referenced
this pull request
Mar 16, 2026
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.