Skip to content

[PWGLF] Optimisation and linter fixes for spectraTOF#14947

Merged
maciacco merged 1 commit intoAliceO2Group:masterfrom
tonmoySh:o2linterErrWarn_fixed
Feb 17, 2026
Merged

[PWGLF] Optimisation and linter fixes for spectraTOF#14947
maciacco merged 1 commit intoAliceO2Group:masterfrom
tonmoySh:o2linterErrWarn_fixed

Conversation

@tonmoySh
Copy link
Copy Markdown
Contributor

  • Replaced hard-coded PDG codes with named constants from PhysicsConstant.h
  • Replaced the "magic numbers" in the expressions constexpr values
  • updated the variable and function names to follow standard naming convention (lowerCamelCase)
  • updated the configurable names to follow standard naming convention (lowerCamelCase)
  • updated the macro names to follow standard naming convention (SCREAMING_SNAKE_CASE)
  • Changed the struct name "tofSpectra" to "SpectraTOF" to follow standard naming convention (UpperCamelCase) as well as to match with the Workflow file name (spectraTOF.cxx)
  • other minor optimisations

@github-actions github-actions bot removed the pwghf PWG-HF label Feb 12, 2026
@github-actions github-actions bot changed the title [PWGLF - Nuspex] Optimisation and linter fixes for spectraTOF [PWGLF,-,Nuspex] Optimisation and linter fixes for spectraTOF Feb 12, 2026
@tonmoySh tonmoySh changed the title [PWGLF,-,Nuspex] Optimisation and linter fixes for spectraTOF [PWGLF-Nuspex] Optimisation and linter fixes for spectraTOF Feb 12, 2026
@github-actions github-actions bot changed the title [PWGLF-Nuspex] Optimisation and linter fixes for spectraTOF [PWGLF] [PWGLF-Nuspex] Optimisation and linter fixes for spectraTOF Feb 12, 2026
@tonmoySh tonmoySh changed the title [PWGLF] [PWGLF-Nuspex] Optimisation and linter fixes for spectraTOF [PWGLF] Optimisation and linter fixes for spectraTOF Feb 12, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8bba576 at 2026-02-13 02:18:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:48: error: 'doprocessFullEl' was not declared in this scope
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:65: error: 'doprocessFullMu' was not declared in this scope
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:82: error: 'doprocessFullPi' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:99: error: 'doprocessFullKa' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:116: error: 'doprocessFullPr' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:133: error: 'doprocessFullDe' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:150: error: 'doprocessFullTr' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:167: error: 'doprocessFullHe' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:83:184: error: 'doprocessFullAl' was not declared in this scope; did you mean 'doprocessFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:50: error: 'doprocessLfFullEl' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:69: error: 'doprocessLfFullMu' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:88: error: 'doprocessLfFullPi' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:107: error: 'doprocessLfFullKa' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:126: error: 'doprocessLfFullPr' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:145: error: 'doprocessLfFullDe' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:164: error: 'doprocessLfFullTr' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:183: error: 'doprocessLfFullHe' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:85:202: error: 'doprocessLfFullAl' was not declared in this scope; did you mean 'doprocessLfFullParticle'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:306:5: error: two or more data types in declaration of 'h'
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:323:5: error: 'h' was not declared in this scope
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1930:98: error: 'DcaMaxCombinedSigma' was not declared in this scope
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1931:25: error: 'DcaTrkPtCut' was not declared in this scope
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1932:42: error: 'DcaMaxTPCSigma' was not declared in this scope
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1992:38: error: 'kD0' was not declared in this scope; did you mean 'o2::constants::physics::kD0'?
/sw/SOURCES/O2Physics/14947-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2722:37: error: 'cfgCutEtaMax' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

maciacco
maciacco previously approved these changes Feb 15, 2026
@maciacco maciacco marked this pull request as draft February 15, 2026 10:17
@tonmoySh tonmoySh force-pushed the o2linterErrWarn_fixed branch from 8bba576 to af6bed4 Compare February 15, 2026 23:01
@tonmoySh tonmoySh marked this pull request as ready for review February 16, 2026 00:01
@tonmoySh tonmoySh requested a review from maciacco February 17, 2026 00:26
@maciacco maciacco enabled auto-merge (squash) February 17, 2026 08:00
@maciacco maciacco merged commit 89b15c7 into AliceO2Group:master Feb 17, 2026
12 checks passed
@tonmoySh tonmoySh deleted the o2linterErrWarn_fixed branch February 17, 2026 08:22
comrademarvin pushed a commit to comrademarvin/O2Physics that referenced this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants