Skip to content

[ALICE3] Add hasValue and replaceValue methods to GeometryEntry#14813

Merged
dsekihat merged 4 commits intomasterfrom
njacazio-patch-5
Feb 6, 2026
Merged

[ALICE3] Add hasValue and replaceValue methods to GeometryEntry#14813
dsekihat merged 4 commits intomasterfrom
njacazio-patch-5

Conversation

@njacazio
Copy link
Copy Markdown
Collaborator

@njacazio njacazio commented Feb 5, 2026

@github-actions github-actions bot added the alice3 label Feb 5, 2026
@github-actions github-actions bot changed the title Add hasValue and replaceValue methods to GeometryEntry [ALICE3] Add hasValue and replaceValue methods to GeometryEntry Feb 5, 2026
@njacazio njacazio marked this pull request as ready for review February 5, 2026 08:04
@njacazio njacazio enabled auto-merge (squash) February 5, 2026 08:05
alibuild
alibuild previously approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
Log warning for empty layer names in configuration
9a4a89a 
Added warning log for empty layer names in geometry configuration.
@njacazio njacazio disabled auto-merge February 5, 2026 08:28
@njacazio njacazio enabled auto-merge (squash) February 5, 2026 08:28
alibuild
alibuild previously approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Feb 5, 2026

Error while checking build/O2Physics/o2 for 9a4a89a at 2026-02-05 09:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14813-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:37:59: error: no declaration matches 'std::map<std::__cxx11::basic_string<char>, std::map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > > o2::fastsim::GeometryContainer::parseTEnvConfiguration(std::string, std::vector<std::__cxx11::basic_string<char> >&)'
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio disabled auto-merge February 5, 2026 20:50
@njacazio njacazio enabled auto-merge (squash) February 5, 2026 20:50
alibuild
alibuild approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@dsekihat dsekihat disabled auto-merge February 6, 2026 15:11
@dsekihat dsekihat merged commit 4949b44 into master Feb 6, 2026
12 of 13 checks passed
@dsekihat dsekihat deleted the njacazio-patch-5 branch February 6, 2026 15:11
comrademarvin pushed a commit to comrademarvin/O2Physics that referenced this pull request Mar 16, 2026
@njacazio @comrademarvin
[ALICE3] Add hasValue and replaceValue methods to GeometryEntry (Alic…
1a61b92 
…eO2Group#14813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild @dsekihat