Merged
Conversation
space removed
|
Preview was deployed to: https://pull-request-855.kb-adg.pages.dev/ |
an-martynova
requested review from
adbuker
and removed request for
el-termikael
adbuker
approved these changes
Apr 14, 2026
owlsy
suggested changes
Apr 14, 2026
| @@ -113,7 +113,7 @@ Host: example.org` | |||
| will be converted to | |||
|
|
|||
| `GET /foo/bar/ HTTP/1.1 | |||
There was a problem hiding this comment.
Just using two regular spaces will not correctly show on the page (it will just show one space).
We should ensure the spaces between GET and /foo/bar/ are using the Unicode em space (8195 in UTF-8).
Markdown code:
`GET /foo/bar/ HTTP/1.1
Host:example.org`
owlsy
added a commit
to owlsy/KnowledgeBase
that referenced
this pull request
Apr 14, 2026
As mentioned several times in AdguardTeam#848, AdguardTeam#853, and AdguardTeam#855, just using two regular spaces will not correctly show on the page. It will just show one space. The second space between GET and /foo/bar/ should be using the Unicode em space (8195 in UTF-8) to resolve this.
owlsy
added a commit
to owlsy/KnowledgeBase
that referenced
this pull request
Apr 14, 2026
As mentioned several times in AdguardTeam#848, AdguardTeam#853, and AdguardTeam#855, just using two regular spaces continues to not show correctly on the page. It just shows one space. The second space between GET and /foo/bar/ should be using the Unicode em space (8195 in UTF-8). Creating a PR myself to resolve this, as I have been ignored. Closes AdguardTeam#853.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
space removed, now expecting a correct presentation on the page