fix: windows core count from powershell#2108
Open
maxnbk wants to merge 2 commits into
Open
Conversation
…th wmic fallback Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2108 +/- ##
==========================================
+ Coverage 60.65% 60.69% +0.04%
==========================================
Files 164 164
Lines 20584 20598 +14
Branches 3579 3580 +1
==========================================
+ Hits 12485 12502 +17
+ Misses 7224 7220 -4
- Partials 875 876 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2029 .
Explanation:
wmicwas removed as a default install in Windows 11 24H2, causing rez to fail at startup when physical core count is computed.Fix:
Replace it with a
PowerShell/Get-CimInstanceequivalent -powershell.exe(Windows PowerShell 5.1) ships with all Windows 10/11 installs and is guaranteed available. The oldwmicpath is retained as a fallback for older Windows builds.Disclosure:
This PR was AI-assisted with Claude Code, Sonnet 4.6, primarily for diagnostics, logic-tracing, documentation and edge-case verification.