fix: windows case sensitivity in pkg cache variants uri#2107
Open
maxnbk wants to merge 2 commits into
Open
Conversation
…sensitive path handling Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
…ng pkg-cache operations Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
=======================================
Coverage 60.65% 60.65%
=======================================
Files 164 164
Lines 20584 20584
Branches 3579 3579
=======================================
Hits 12485 12485
Misses 7224 7224
Partials 875 875 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2101 .
Explanation:
get_package_from_uriin the filesystem package repository appliedos.path.normcaseto the entire URI before slicing out the package name and version. On Windows,normcaselowercases the whole string, silently corrupting mixed-case names (FooBar->foobar) and versions (1.0B->1.0b) before they were used for lookup, causing both to returnNone.Fix:
We scope the
normcaseusage to theis_subdirectoryboundary check only. The subsequent name/version extraction slices from the original URI, preserving caller-supplied casing.Disclosure:
This PR was AI-assisted with Claude Code, Sonnet 4.6, primarily for diagnostics, logic-tracing, documentation and edge-case verification.