AMQP Context Tracking connection error handling#2106
Open
sanikache wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ibrahim Sani <Ibrahim.Sani@dreamworks.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2106 +/- ##
==========================================
- Coverage 60.65% 60.62% -0.03%
==========================================
Files 164 164
Lines 20584 20594 +10
Branches 3579 3583 +4
==========================================
Hits 12485 12485
- Misses 7224 7233 +9
- Partials 875 876 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I like the change, it seems solid overall, but I will just want to wait for @JeanChristopheMorinPerso to comment. @sanikache : Since the cov-bot is basically mostly complaining that nothing hits inside the logging-conf block, I'm wondering if a mocked test-module could hit this codepath without needing an actual AMQP server to hit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JeanChristopheMorinPerso and I were discussing this over #1968
Pika's vendor library was emitting ERROR-level log messages whenever a broker connection failed, even when context tracking was not configured. This produced spurious output in normal rez usage.
Changes:
init.py: Set rez.vendor.pika logger to CRITICAL at startup, silencing all pika output by default.
amqp.py:
Here's the new behavior with this change after pointing context_tracking_host to a fake host:
To enabling context_tracking to see the full stacktrace: