Skip to content

Fix version check for tabulate package #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
momchil-velikov wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix version check for tabulate package #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ RUN apt-get update \
inkscape \
python3 \
python3-tabulate \
python3-packaging \
librsvg2-bin \
&& rm -rf /var/lib/apt/lists/*

Expand Down
3 changes: 2 additions & 1 deletion tools/gen-intrinsics-specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import doctest
from urllib.parse import urljoin
from urllib.parse import quote
from packaging.version import Version

def quote_literal(val, workflow):
if len(val) > 0:
Expand Down Expand Up @@ -955,7 +956,7 @@ def get_intrinsics_db(path):

# We require version 0.8.6 to be able to print multi-line records
# in tables.
if tbl.__version__ < "0.8.6":
if Version(tbl.__version__) < Version("0.8.6"):
print(f"Your version of package tabulate is too old ({tbl.__version__}). "
"Update it to be greater or equal to 0.8.6.", file=sys.stderr)
exit(1)
Expand Down
Loading