Skip to content

Add netcdf file for mrsofc#246

Open
Whyborn wants to merge 1 commit intomainfrom
add-mrosfc-variable-resource
Open

Add netcdf file for mrsofc#246
Whyborn wants to merge 1 commit intomainfrom
add-mrosfc-variable-resource

Conversation

@Whyborn
Copy link
Copy Markdown
Collaborator

@Whyborn Whyborn commented Mar 31, 2026

This PR adds the NetCDF file for the mrsofc (soil_moisture_content_at_field_capacity) variable. This is taken from an atmosphere restart file, in combination with the CABLE soil layer thicknesses, which are not included anywhere in the ESM1.6 input or output information as far as I'm aware. The contents of the file are:

[lw5085@gadi-login-04 ~]$ ncdump -h mrsofc_fx_ACCESS-ESM1-6.nc 
netcdf mrsofc_fx_ACCESS-ESM1-6 {
dimensions:
	lon = 192 ;
	lat = 145 ;
variables:
	double lon(lon) ;
		lon:_FillValue = NaN ;
		lon:units = "degrees_east" ;
	double lat(lat) ;
		lat:_FillValue = NaN ;
		lat:units = "degrees_north" ;
	double mrsofc(lat, lon) ;
		mrsofc:_FillValue = NaN ;
		mrsofc:standard_name = "soil_moisture_content_at_field_capacity" ;
		mrsofc:long_name = "Capacity of Soil to Store Water (Field Capacity)" ;
		mrsofc:units = "kg m-2" ;
		mrsofc:cell_methods = "area: mean where land" ;
		mrsofc:modelling_realm = "land" ;
		mrsofc:processing_notes = "Excludes lake water and refers to soil water only." ;
}

I can easily add any additional metadata if necessary, and a description somewhere.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.5%. Comparing base (cde9572) to head (8ac327e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #246   +/-   ##
=====================================
  Coverage   54.5%   54.5%           
=====================================
  Files         20      20           
  Lines       3866    3866           
  Branches     714     714           
=====================================
  Hits        2106    2106           
  Misses      1581    1581           
  Partials     179     179           
Flag Coverage Δ
unit 54.5% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Whyborn Whyborn requested a review from rbeucher March 31, 2026 05:39
@rbeucher rbeucher assigned rhaegar325 and unassigned rhaegar325 Mar 31, 2026
Copy link
Copy Markdown
Collaborator

@rhaegar325 rhaegar325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mrsofc variable is not yet included in the current ACCESS-ESM1.6_mappings. It will be tested after the relevant variable information is added to the mappings.

related pr #220

@Whyborn
Copy link
Copy Markdown
Collaborator Author

Whyborn commented Apr 7, 2026

@rhaegar325 do you require any action from me at this point?

@rhaegar325
Copy link
Copy Markdown
Collaborator

The mrsofc variable is not yet included in the current ACCESS-ESM1.6_mappings. It will be tested after the relevant variable information is added to the mappings.

related pr #220

Not for now, we’d like to first improve the functionality for directly reading data from NetCDF files. We’ll come back to test this PR once that is in place. Thanks again for your help @Whyborn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants