Skip to content

THREESCALE-10619 Increase default password to 23 characters#1147

Merged
tkan145 merged 1 commit into3scale:masterfrom
tkan145:THREESCALE-10619-strong-password
Mar 30, 2026
Merged

THREESCALE-10619 Increase default password to 23 characters#1147
tkan145 merged 1 commit into3scale:masterfrom
tkan145:THREESCALE-10619-strong-password

Conversation

@tkan145
Copy link
Copy Markdown
Contributor

@tkan145 tkan145 commented Mar 10, 2026

What

Fix THREESCALE-10619

Verification steps

  • Checkout this branch
  • Prepare cluster
make cluster/prepare/local
  • Install APIM
export NAMESPACE=3scale-test

cat << EOF | oc create -f -
kind: Secret
apiVersion: v1
metadata:
  name: s3-credentials
  namespace: $NAMESPACE
data:
  AWS_ACCESS_KEY_ID: c29tZXRoaW5nCg==
  AWS_BUCKET: c29tZXRoaW5nCg==
  AWS_REGION: dXMtd2VzdC0xCg==
  AWS_SECRET_ACCESS_KEY: c29tZXRoaW5nCg==
type: Opaque
EOF

DOMAIN=$(oc get routes console -n openshift-console -o json | jq -r '.status.ingress[0].routerCanonicalHostname' | sed 's/router-default.//')
cat << EOF | oc create -f -
kind: APIManager
apiVersion: apps.3scale.net/v1alpha1
metadata:
  name: 3scale
  namespace: $NAMESPACE
spec:
  wildcardDomain: $DOMAIN
  apicast:
    stagingSpec:
      replicas: 0
    productionSpec:
      replicas: 0
  system:
    fileStorage:
      simpleStorageService:
        configurationSecretRef:
          name: s3-credentials
  externalComponents:
    backend:
      redis: true
    system:
      database: true
      redis: true
EOF
  • Start the operator
make run
  • Wait for the installation to finish
  • Check system-seed secret, you should see the password in the form of 5char-5char-5char-5char
  • Try to login to admin/master portal, you should be able to login without any issue

@tkan145 tkan145 requested a review from a team as a code owner March 10, 2026 04:01
@tkan145 tkan145 force-pushed the THREESCALE-10619-strong-password branch from 99f15ad to 470bccb Compare March 27, 2026 05:20
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.36%. Comparing base (5201978) to head (bdb184e).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   39.33%   39.36%   +0.03%     
==========================================
  Files         205      205              
  Lines       23371    23379       +8     
==========================================
+ Hits         9193     9204      +11     
+ Misses      13192    13188       -4     
- Partials      986      987       +1     
Flag Coverage Δ
unit 39.36% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

urbanikb
urbanikb previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@urbanikb urbanikb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be in order, all secrets (system-seed, system-events-hook, system-master-apicast, backend-internal-api) have been seeded correctly. UI login is successful so the complexity of the password is sufficient for the system app 👍

Comment thread pkg/3scale/amp/component/system_options.go Outdated
@tkan145 tkan145 force-pushed the THREESCALE-10619-strong-password branch from 470bccb to bdb184e Compare March 30, 2026 02:56
@tkan145 tkan145 changed the title THREESCALE-10619 Increase password and access token to 16 characters THREESCALE-10619 Increase default password to 23 characters Mar 30, 2026
@tkan145 tkan145 merged commit d796c4b into 3scale:master Mar 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants