Draft
Conversation
…v0.14 devnet address
…ion code to devnet
…e tutorial
The @miden-sdk/miden-sdk v0.14.0 send({ returnNote: true }) path passes
OutputNoteArray to withOwnOutputNotes() which now expects NoteArray.
Use TransactionRequestBuilder directly until the SDK fix is released.
Tracking: 0xMiden/miden-client#2011
Keinberger
force-pushed
the
kbg/chore/v14-migration
branch
from
7630916 to
6876cc9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…, remove localStorage polyfill
…th webpack SDK v0.14.1 changed the worker from ES module to classic script for Safari. The classic worker resolves WASM via self.location.href which webpack can't trace, causing a 404. Disabling Worker forces the main-thread fallback which uses import.meta.url (webpack-compatible). Proving is slower but correct. Tracking: 0xMiden/miden-client#2046
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all tutorial companion code, documentation, and MASM sources from v0.13 to the v0.14 Miden stack. Targets devnet for validation.
Changes
Key v0.14 Fixes
push.A.B.C.D) to hex word (push.0x...) format for v0.14 little-endian stack orderingexecute_foreign_procedurerequires 16 explicit inputs (padw×4) and returns 16 elements (dropw×4)send({ returnNote: true })broken in SDK v0.14.0 (Bug: send({ returnNote: true }) broken: OutputNoteArray vs NoteArray type mismatch miden-client#2011) — workaround uses TransactionRequestBuilder directlyVerification
Known Workarounds (tracked)
web-client/lib/unauthenticatedNoteTransfer.ts— manual TransactionRequestBuilder instead ofsend({ returnNote: true })(Bug: send({ returnNote: true }) broken: OutputNoteArray vs NoteArray type mismatch miden-client#2011)web-client/lib/multiSendWithDelegatedProver.ts— type cast forcreateP2IDNotereturn type (SDK .d.ts mismatch)Closes #175