Skip to content

Support int, float and bool values for FilterBy escape #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tharropoulos merged 3 commits into from
Mar 5, 2026
Merged

Support int, float and bool values for FilterBy escape #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d9b369
Support int, float and bool values for FilterBy escape
alexander-schranz Mar 5, 2026
9c3c63e
Change escape method to static in FilterBy class
alexander-schranz Mar 5, 2026
da6a6fe
Refactor escapeString to escape method in tests
alexander-schranz Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/FilterBy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@

class FilterBy
{
public static function escapeString(string $value): string
public static function escape(string|int|float|bool $value): string
{
return '`' . str_replace('`', '\\`', $value) . '`';
return match (true) {
is_string($value) => '`' . str_replace('`', '\\`', $value) . '`',
is_bool($value) => $value ? 'true' : 'false',
default => (string) $value,
};
}
}
32 changes: 30 additions & 2 deletions tests/Feature/FilterByTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public function testEscapesSpecialCharactersByWrappingInBackticks(): void
{
$rawFilterValue = "The 17\" O'Conner && O`Series \n OR a || 1%2 book? (draft), [alpha]";

$escapedFilterValue = FilterBy::escapeString($rawFilterValue);
$escapedFilterValue = FilterBy::escape($rawFilterValue);

$this->assertSame(
"`The 17\" O'Conner && O\\`Series \n OR a || 1%2 book? (draft), [alpha]`",
Expand All @@ -21,8 +21,36 @@ public function testEscapesSpecialCharactersByWrappingInBackticks(): void

public function testEscapesMultipleBackticksWithinAFilterString(): void
{
$escapedFilterValue = FilterBy::escapeString('`left` and `right`');
$escapedFilterValue = FilterBy::escape('`left` and `right`');

$this->assertSame('`\\`left\\` and \\`right\\``', $escapedFilterValue);
}

public function testEscapeBooleanTrue(): void
{
$escapedFilterValue = FilterBy::escape(true);

$this->assertSame('true', $escapedFilterValue);
}

public function testEscapeBooleanFalse(): void
{
$escapedFilterValue = FilterBy::escape(false);

$this->assertSame('false', $escapedFilterValue);
}

public function testEscapeFloat(): void
{
$escapedFilterValue = FilterBy::escape(1.12);

$this->assertSame('1.12', $escapedFilterValue);
}

public function testEscapeInt(): void
{
$escapedFilterValue = FilterBy::escape(1);

$this->assertSame('1', $escapedFilterValue);
}
}