diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a946be6..6569efb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,12 +2,13 @@ name: ci on: push: branches-ignore: - - master + - main pull_request: branches-ignore: - master jobs: test: + if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.base.repo.full_name == github.repository) }} runs-on: ubuntu-22.04 services: mssql: @@ -57,6 +58,7 @@ jobs: COVERALLS_PARALLEL: true coveralls: + if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.base.repo.full_name == github.repository) }} name: Finish Coveralls needs: test runs-on: ubuntu-22.04 diff --git a/asyncodbc/pool.py b/asyncodbc/pool.py index d1001f1..a43f223 100644 --- a/asyncodbc/pool.py +++ b/asyncodbc/pool.py @@ -192,7 +192,7 @@ async def release(self, conn): self._terminated.remove(conn) return self._used.remove(conn) - if not conn.closed: + if conn.connected and not conn.closed: if self._closing: await conn.close() else: diff --git a/tests/test_pool.py b/tests/test_pool.py index eee8623..50ef36e 100644 --- a/tests/test_pool.py +++ b/tests/test_pool.py @@ -60,9 +60,9 @@ async def test_release_closed(pool): assert 0 == pool.freesize await conn.close() await pool.release(conn) - assert 1 == pool.freesize + assert 0 == pool.freesize assert not pool._used - assert 1 == pool.size + assert 0 == pool.size conn2 = await pool.acquire() assert 0 == pool.freesize