Single line comments comment to the end of the query statement

[drkelly58]

The following query:

Select * from players
-- adding a where clause that should return 0 records
where 1=0

Should return 0 records but returns all records because the where clause ends up as part of the comment

[drkelly58]

I realized after my initial post that this can be resolved by passing false to the execute method, but I think that since the default functionality is prepare_for_logs it should either strip the comments or add a <cr> after them.

Also, if current is the preferred result then at-least make an explicit note about that in your readme docs

[sufleR]

It may be better to always use multiline comments https://www.w3schools.com/sql/sql_comments.asp
In that case comment will be always in the same place:

SELECT 
  id,
   /* name, */ 
  last_name
FROM
  users

the result would be

SELECT  id, /* name, */ last_name FROM users

It does not make sense to keep single line comment on the end of the query as it will be not longer relevant if it will be related to for example SELECT part.

SELECT 
  id,
  -- name, 
  last_name
FROM
  users

the result would be

SELECT id,  last_name FROM users -- name

which doesn't make much sense.

I will add option to remove comments from SQL as it is good addition in my opinion.

[drkelly58]

Instead of an option, I think just removing single line comments from prepared query makes a lot of sense.
Comments are generally to help readability, and have no purpose in a prepared query (in my opinion)

[sufleR]

@drkelly58 In next release all comments will be removed by default.