Linker: Add better exception handling and safer operations#39
Merged
Conversation
Wrap all calls that can potentially raise so we can instead forward a clean error case Ensure all path operations in createRC use dynamic arrays instead of cstyle arrays and add explicit handling for long paths Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
reviewed
May 20, 2026
| link_run.makeRsp(); | ||
| } catch (const FileIOError& e) { | ||
| return ExitConditions::FILE_IO_FAILURE; | ||
| } |
Member
There was a problem hiding this comment.
Follow-up: see if we can get traceback when exceptions are thrown
Or: surround whole method in try/catch, then unwrap for more info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap all calls that can potentially raise so we can instead forward a clean error case
Ensure all path operations in createRC use dynamic arrays instead of cstyle arrays and add explicit handling for long paths